pgsql: Convert contrib/hstore_plpython to not use direct linking to oth
От | Tom Lane |
---|---|
Тема | pgsql: Convert contrib/hstore_plpython to not use direct linking to oth |
Дата | |
Msg-id | E1brFRx-0003Aq-Ea@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Convert contrib/hstore_plpython to not use direct linking to other modules. Previously, on most platforms, we allowed hstore_plpython's references to hstore and plpython to be unresolved symbols at link time, trusting the dynamic linker to resolve them when the module is loaded. This has a number of problems, the worst being that the dynamic linker does not know where the references come from and can do nothing but fail if those other modules haven't been loaded. We've more or less gotten away with that for the limited use-case of datatype transform modules, but even there, it requires some awkward hacks, most recently commit 83c249200. Instead, let's not treat these references as linker-resolvable at all, but use function pointers that are manually filled in by the module's _PG_init function. There are few enough contact points that this doesn't seem unmaintainable, at least for these use-cases. (Note that the same technique wouldn't work at all for decoupling from libpython itself, but fortunately that's just a standard shared library and can be linked to normally.) This is an initial patch that just converts hstore_plpython. If the buildfarm doesn't find any fatal problems, I'll work on the other transform modules soon. Tom Lane, per an idea of Andres Freund's. Discussion: <2652.1475512158@sss.pgh.pa.us> Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/d51924be886c2a05e691fa05b16cb6b30ab8370f Modified Files -------------- contrib/hstore_plpython/Makefile | 19 +++---- contrib/hstore_plpython/hstore_plpython.c | 65 ++++++++++++++++++++++ contrib/hstore_plpython/hstore_plpython2u--1.0.sql | 5 -- contrib/hstore_plpython/hstore_plpython3u--1.0.sql | 5 -- contrib/hstore_plpython/hstore_plpythonu--1.0.sql | 5 -- src/tools/msvc/Mkvcbuild.pm | 3 +- 6 files changed, 76 insertions(+), 26 deletions(-)
В списке pgsql-committers по дате отправления: