pgsql: Fix ruleutils.c's dumping of whole-row Vars in ROW() and VALUES(
От | Tom Lane |
---|---|
Тема | pgsql: Fix ruleutils.c's dumping of whole-row Vars in ROW() and VALUES( |
Дата | |
Msg-id | E1Zy3BK-0006n7-0F@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix ruleutils.c's dumping of whole-row Vars in ROW() and VALUES() contexts. Normally ruleutils prints a whole-row Var as "foo.*". We already knew that that doesn't work at top level of a SELECT list, because the parser would treat the "*" as a directive to expand the reference into separate columns, not a whole-row Var. However, Joshua Yanovski points out in bug #13776 that the same thing happens at top level of a ROW() construct; and some nosing around in the parser shows that the same is true in VALUES(). Hence, apply the same workaround already devised for the SELECT-list case, namely to add a forced cast to the appropriate rowtype in these cases. (The alternative of just printing "foo" was rejected because it is difficult to avoid ambiguity against plain columns named "foo".) Back-patch to all supported branches. Branch ------ REL9_4_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/d33ab56b0ee3dbb5a353bf07804820f1daa199d5 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 35 +++++++++-- src/test/regress/expected/create_view.out | 91 +++++++++++++++++++++++++++++ src/test/regress/sql/create_view.sql | 18 ++++++ 3 files changed, 139 insertions(+), 5 deletions(-)
В списке pgsql-committers по дате отправления: