pgsql: Further fix for psql's code for locale-aware formatting of numer
От | Tom Lane |
---|---|
Тема | pgsql: Further fix for psql's code for locale-aware formatting of numer |
Дата | |
Msg-id | E1ZfKCT-0006k4-5f@gemulon.postgresql.org обсуждение исходный текст |
Ответы |
Re: pgsql: Further fix for psql's code for
locale-aware formatting of numer
|
Список | pgsql-committers |
Further fix for psql's code for locale-aware formatting of numeric output. On closer inspection, those seemingly redundant atoi() calls were not so much inefficient as just plain wrong: the author of this code either had not read, or had not understood, the POSIX specification for localeconv(). The grouping field is *not* a textual digit string but separate integers encoded as chars. We'll follow the existing code as well as the backend's cash.c in only honoring the first group width, but let's at least honor it correctly. This doesn't actually result in any behavioral change in any of the locales I have installed on my Linux box, which may explain why nobody's complained; grouping width 3 is close enough to universal that it's barely worth considering other cases. Still, wrong is wrong, so back-patch. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/6325527d845b629243fb3f605af6747a7a4ac45f Modified Files -------------- src/bin/psql/print.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
В списке pgsql-committers по дате отправления: