pgsql: Fix s_lock.h PPC assembly code to be compatible with native AIX
От | Tom Lane |
---|---|
Тема | pgsql: Fix s_lock.h PPC assembly code to be compatible with native AIX |
Дата | |
Msg-id | E1ZVmRk-0004hz-2f@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix s_lock.h PPC assembly code to be compatible with native AIX assembler. On recent AIX it's necessary to configure gcc to use the native assembler (because the GNU assembler hasn't been updated to handle AIX 6+). This caused PG builds to fail with assembler syntax errors, because we'd try to compile s_lock.h's gcc asm fragment for PPC, and that assembly code relied on GNU-style local labels. We can't substitute normal labels because it would fail in any file containing more than one inlined use of tas(). Fortunately, that code is stable enough, and the PPC ISA is simple enough, that it doesn't seem like too much of a maintenance burden to just hand-code the branch offsets, removing the need for any labels. Note that the AIX assembler only accepts "$" for the location counter pseudo-symbol. The usual GNU convention is "."; but it appears that all versions of gas for PPC also accept "$", so in theory this patch will not break any other PPC platforms. This has been reported by a few people, but Steve Underwood gets the credit for being the first to pursue the problem far enough to understand why it was failing. Thanks also to Noah Misch for additional testing. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/c41a1215f04912108068b909569551f42059db29 Modified Files -------------- src/include/storage/s_lock.h | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
В списке pgsql-committers по дате отправления: