pgsql: Explicitly support the case that a plancache's raw_parse_tree is
От | Tom Lane |
---|---|
Тема | pgsql: Explicitly support the case that a plancache's raw_parse_tree is |
Дата | |
Msg-id | E1Xof0X-0002Ef-LV@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Explicitly support the case that a plancache's raw_parse_tree is NULL. This only happens if a client issues a Parse message with an empty query string, which is a bit odd; but since it is explicitly called out as legal by our FE/BE protocol spec, we'd probably better continue to allow it. Fix by adding tests everywhere that the raw_parse_tree field is passed to functions that don't or shouldn't accept NULL. Also make it clear in the relevant comments that NULL is an expected case. This reverts commits a73c9dbab0165b3395dfe8a44a7dfd16166963c4 and 2e9650cbcff8c8fb0d9ef807c73a44f241822eee, which fixed specific crash symptoms by hacking things at what now seems to be the wrong end, ie the callee functions. Making the callees allow NULL is superficially more robust, but it's not always true that there is a defensible thing for the callee to do in such cases. The caller has more context and is better able to decide what the empty-query case ought to do. Per followup discussion of bug #11335. Back-patch to 9.2. The code before that is sufficiently different that it would require development of a separate patch, which doesn't seem worthwhile for what is believed to be an essentially cosmetic change. Branch ------ REL9_3_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/c2b4ed19f6b64fa56fee5b6241463b499144f23e Modified Files -------------- src/backend/executor/spi.c | 4 +++- src/backend/parser/analyze.c | 6 +----- src/backend/tcop/postgres.c | 4 +++- src/backend/tcop/utility.c | 5 +---- src/backend/utils/cache/plancache.c | 9 ++++++--- src/include/utils/plancache.h | 2 +- 6 files changed, 15 insertions(+), 15 deletions(-)
В списке pgsql-committers по дате отправления: