pgsql: Don't attempt to limit target database for pg_restore.
От | Kevin Grittner |
---|---|
Тема | pgsql: Don't attempt to limit target database for pg_restore. |
Дата | |
Msg-id | E1VxNqV-0008Gs-SY@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Don't attempt to limit target database for pg_restore. There was an apparent attempt to limit the target database for pg_restore to version 7.1.0 or later. Due to a leading zero this was interpreted as an octal number, which allowed targets with version numbers down to 2.87.36. The lowest actual release above that was 6.0.0, so that was effectively the limit. Since the success of the restore attempt will depend primarily on on what statements were generated by the dump run, we don't want pg_restore trying to guess whether a given target should be allowed based on version number. Allow a connection to any version. Since it is very unlikely that anyone would be using a recent version of pg_restore to restore to a pre-6.0 database, this has little to no practical impact, but it makes the code less confusing to read. Issue reported and initial patch suggestion from Joel Jacobson based on an article by Andrey Karpov reporting on issues found by PVS-Studio static code analyzer. Final patch based on analysis by Tom Lane. Back-patch to all supported branches. Branch ------ REL9_1_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/c41f036445f8dff705139a6d0f3727991b4fe964 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
В списке pgsql-committers по дате отправления: