pgsql: pg_upgrade: Split off pg_fatal() from pg_log()

pg_upgrade: Split off pg_fatal() from pg_log()

This allows decorating pg_fatal() with noreturn compiler hints, leading
to better diagnostics.

Reviewed-by: Marko Tiikkaja <marko@joh.to>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/264aa14a2f687eba8c8cc2a5b6cbd6397973da98

Modified Files
--------------
contrib/pg_upgrade/check.c           |   68 +++++++++++--------------
contrib/pg_upgrade/controldata.c     |   92 +++++++++++++++-------------------
contrib/pg_upgrade/exec.c            |   21 ++++----
contrib/pg_upgrade/file.c            |    3 +-
contrib/pg_upgrade/function.c        |   11 ++--
contrib/pg_upgrade/info.c            |    6 +--
contrib/pg_upgrade/option.c          |   23 ++++-----
contrib/pg_upgrade/page.c            |    6 +--
contrib/pg_upgrade/parallel.c        |   12 ++---
contrib/pg_upgrade/pg_upgrade.c      |    8 +--
contrib/pg_upgrade/pg_upgrade.h      |    5 +-
contrib/pg_upgrade/relfilenode.c     |   11 ++--
contrib/pg_upgrade/server.c          |   11 ++--
contrib/pg_upgrade/tablespace.c      |    3 +-
contrib/pg_upgrade/util.c            |   35 ++++++++++---
contrib/pg_upgrade/version.c         |    2 +-
contrib/pg_upgrade/version_old_8_3.c |   23 ++++-----
17 files changed, 166 insertions(+), 174 deletions(-)