pgsql: Don't advance checkPoint.nextXid near the end of a checkpoint se
От | Tom Lane |
---|---|
Тема | pgsql: Don't advance checkPoint.nextXid near the end of a checkpoint se |
Дата | |
Msg-id | E1TfG2J-0004Rw-7C@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Don't advance checkPoint.nextXid near the end of a checkpoint sequence. This reverts commit c11130690d6dca64267201a169cfb38c1adec5ef in favor of actually fixing the problem: namely, that we should never have been modifying the checkpoint record's nextXid at this point to begin with. The nextXid should match the state as of the checkpoint's logical WAL position (ie the redo point), not the state as of its physical position. It's especially bogus to advance it in some wal_levels and not others. In any case there is no need for the checkpoint record to carry the same nextXid shown in the XLOG_RUNNING_XACTS record just emitted by LogStandbySnapshot, as any replay operation will already have adopted that value as current. This fixes bug #7710 from Tarvi Pillessaar, and probably also explains bug #6291 from Daniel Farina, in that if a checkpoint were in progress at the instant of XID wraparound, the epoch bump would be lost as reported. (And, of course, these days there's at least a 50-50 chance of a checkpoint being in progress at any given instant.) Diagnosed by me and independently by Andres Freund. Back-patch to all branches supporting hot standby. Branch ------ REL9_0_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/135f4f605517deb97fed60811ebca32ff94a8488 Modified Files -------------- src/backend/access/transam/xlog.c | 11 +---------- src/backend/storage/ipc/standby.c | 4 +--- src/include/storage/standby.h | 2 +- 3 files changed, 3 insertions(+), 14 deletions(-)
В списке pgsql-committers по дате отправления: