pgsql: More code review for rangetypes patch.

More code review for rangetypes patch.

Fix up some infelicitous coding in DefineRange, and add some missing error
checks.  Rearrange operator strategy number assignments for GiST anyrange
opclass so that they don't make such a mess of opr_sanity's table of
operator names associated with different strategy numbers.  Assign
hopefully-temporary selectivity estimators to range operators that didn't
have one --- poor as the estimates are, they're still a lot better than the
default 0.5 estimate, and they'll shut up the opr_sanity test that wants to
see selectivity estimators on all built-in operators.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a4ffcc8e115ed637f69ecb0295d78cc97f08a483

Modified Files
--------------
src/backend/commands/typecmds.c          |  395 ++++++++++++++++--------------
src/backend/utils/adt/rangetypes_gist.c  |  113 +++++-----
src/include/catalog/catversion.h         |    2 +-
src/include/catalog/pg_amop.h            |   22 +-
src/include/catalog/pg_operator.h        |   12 +-
src/test/regress/expected/opr_sanity.out |   50 ++---
src/test/regress/expected/plpgsql.out    |   14 -
src/test/regress/expected/rangetypes.out |   14 +
src/test/regress/sql/opr_sanity.sql      |   20 +-
src/test/regress/sql/plpgsql.sql         |   10 -
src/test/regress/sql/rangetypes.sql      |    7 +
11 files changed, 342 insertions(+), 317 deletions(-)