pgsql: Fix a passel of inappropriately-named global functions in GIN.
От | Tom Lane |
---|---|
Тема | pgsql: Fix a passel of inappropriately-named global functions in GIN. |
Дата | |
Msg-id | E1P7elU-000496-0l@gemulon.postgresql.org обсуждение исходный текст |
Список | pgsql-committers |
Fix a passel of inappropriately-named global functions in GIN. The GIN code has absolutely no business exporting GIN-specific functions with names as generic as compareItemPointers() or newScanKey(); that's just trouble waiting to happen. I got annoyed about this again just now and decided to fix it. This commit ensures that all global symbols defined in access/gin/ have names including "gin" or "Gin". There were a couple of cases, like names involving "PostingItem", where arguably the names were already sufficiently nongeneric; but I figured as long as I was risking creating merge problems for unapplied GIN patches I might as well impose a uniform policy. I didn't touch any static symbol names. There might be some places where it'd be appropriate to rename some static functions to match siblings that are exported, but I'll leave that for another time. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=419d2374bfbc1eae562121fde31c1aa0e8a164cb Modified Files -------------- src/backend/access/gin/ginbtree.c | 6 ++-- src/backend/access/gin/ginbulk.c | 8 +++--- src/backend/access/gin/gindatapage.c | 30 +++++++++++----------- src/backend/access/gin/ginentrypage.c | 24 ++++++++++-------- src/backend/access/gin/ginfast.c | 2 +- src/backend/access/gin/ginget.c | 43 +++++++++++++++++---------------- src/backend/access/gin/gininsert.c | 17 +++++++------ src/backend/access/gin/ginscan.c | 5 ++- src/backend/access/gin/ginutil.c | 26 ++++++++----------- src/backend/access/gin/ginvacuum.c | 2 +- src/backend/access/gin/ginxlog.c | 12 ++++---- src/include/access/gin.h | 30 +++++++++++----------- 12 files changed, 103 insertions(+), 102 deletions(-)
В списке pgsql-committers по дате отправления: