Re: AIX support

Поиск
Список
Период
Сортировка
Искать
От
Tristan Partin
Тема
Re: AIX support
Дата
Msg-id
DF3QX1B91OKO.182K0IH9QDQUY@partin.io
Ответ на
RE: AIX support (Srirama Kucherlapati)
Список
Дерево обсуждения
AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: AIX support Tom Lane <tgl@sss.pgh.pa.us>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Noah Misch <noah@leadboat.com>
Re: AIX support Tom Lane <tgl@sss.pgh.pa.us>
Re: AIX support Thomas Munro <thomas.munro@gmail.com>
Re: AIX support Thomas Munro <thomas.munro@gmail.com>
Re: AIX support Tom Lane <tgl@sss.pgh.pa.us>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Noah Misch <noah@leadboat.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Heikki Linnakangas <hlinnaka@iki.fi>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Andres Freund <andres@anarazel.de>
Re: AIX support Thomas Munro <thomas.munro@gmail.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Peter Eisentraut <peter@eisentraut.org>
Re: AIX support Tom Lane <tgl@sss.pgh.pa.us>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Bruce Momjian <bruce@momjian.us>
Re: AIX support Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: AIX support Bruce Momjian <bruce@momjian.us>
Re: AIX support Michael Paquier <michael@paquier.xyz>
Re: AIX support Tom Lane <tgl@sss.pgh.pa.us>
Re: AIX support Andres Freund <andres@anarazel.de>
Re: AIX support Peter Eisentraut <peter@eisentraut.org>
Re: AIX support Tom Lane <tgl@sss.pgh.pa.us>
Re: AIX support Michael Paquier <michael@paquier.xyz>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Peter Eisentraut <peter@eisentraut.org>
Re: AIX support Bruce Momjian <bruce@momjian.us>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Noah Misch <noah@leadboat.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: AIX support Sriram RK <sriram.rk@outlook.com>
Re: AIX support Peter Eisentraut <peter@eisentraut.org>
RE: AIX support Srirama Kucherlapati <sriram.rk@in.ibm.com>
Re: AIX support Heikki Linnakangas <hlinnaka@iki.fi>
Re: AIX support Bruce Momjian <bruce@momjian.us>
RE: AIX support Srirama Kucherlapati <sriram.rk@in.ibm.com>
Re: AIX support Laurenz Albe <laurenz.albe@cybertec.at>
RE: AIX support Srirama Kucherlapati <sriram.rk@in.ibm.com>
RE: AIX support Srirama Kucherlapati <sriram.rk@in.ibm.com>
Re: AIX support Heikki Linnakangas <hlinnaka@gmail.com>
RE: AIX support Srirama Kucherlapati <sriram.rk@in.ibm.com>
RE: AIX support Srirama Kucherlapati <sriram.rk@in.ibm.com>
RE: AIX support Srirama Kucherlapati <sriram.rk@in.ibm.com>
Re: AIX support Heikki Linnakangas <hlinnaka@iki.fi>
Re: AIX support Bruce Momjian <bruce@momjian.us>
Re: AIX support "Tristan Partin" <tristan@neon.tech>
Thanks for your continued push for AIX support! Here are a few comments:

> # The static libpq is skipped in AIX. This is not required.

For comments like this, I would generally like to see some links or 
inline documentation to why this is the case. Maybe Peter or Heikki 
disagree.

There are a few places in the Meson code like the following:

	if AIX:
		don't define the static library target
	endif

Make sure that the innards of the if statements are indented. 
Alternatively, you could define something like:

	static_library_dependencies = []
	if host_machine.system() == 'AIX'
		# TODO: Document this
		AIX_poison_pill = disabler()
		static_library_dependencies += AIX_poison_pill
	endif

And then for all static library definitions, you would just make sure 
that they all depend on the poison pill. You could document the AIX 
shared/static library situation where the AIX_poison_pill variable is 
defined. I'd like to see if Peter thinks this is a good idea before 
implementing it.

I'm also a little confused by the second patch. Some of it seems to be 
the same, and some other parts seem to be new. Should we consolidate all 
Meson AIX support into one patch? Overall, I think the size of the patch 
is good, and seem pretty maintainable.

-- 
Tristan Partin
Databricks (https://databricks.com)


В списке pgsql-hackers по дате отправления
От: Kirill Reshke
Дата:
От: Thomas Munro
Дата:
FAQ