Re: Clean up find_typedefs and add support for Mac

On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote:
>
> On 2023-12-12 Tu 18:02, Tom Lane wrote:
> > "Tristan Partin" <tristan@neon.tech> writes:
> >> The big patch here is adding support for Mac. objdump -W doesn't work on
> >> Mac. So, I used dsymutil and dwarfdump to achieve the same result.
> > We should probably nuke the current version of src/tools/find_typedef
> > altogether in favor of copying the current buildfarm code for that.
> > We know that the buildfarm's version works, whereas I'm not real sure
> > that src/tools/find_typedef is being used in anger by anyone.  Also,
> > we're long past the point where developers can avoid having Perl
> > installed.
> >
> > Ideally, the buildfarm client would then start to use find_typedef
> > from the tree rather than have its own copy, both to reduce
> > duplication and to ensure that the in-tree copy keeps working.
> >
> >
>
>
> +1. I'd be more than happy to be rid of maintaining the code. We already
> performed a rather more complicated operation along these lines with the
> PostgreSQL::Test::AdjustUpgrade stuff.

I'll work with you on GitHub to help make the transition. I've already
made a draft PR in the client-code repo, but I am sure I am missing some
stuff.

--
Tristan Partin
Neon (https://neon.tech)