Re: GIN improvements part 1: additional information

<div dir="ltr">On Thu, Jun 27, 2013 at 6:20 PM, Antonin Houska <span dir="ltr"><<a
href="mailto:antonin.houska@gmail.com"target="_blank">antonin.houska@gmail.com</a>></span> wrote:<br /><div
class="gmail_extra"><divclass="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div
class="im">On06/25/2013 12:03 AM, Alexander Korotkov wrote:<br /><blockquote class="gmail_quote" style="margin:0px 0px
0px0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br /><br
/>New revision of patch is attached. Now it includes some docs.<br /><br /><br /></blockquote><br /></div> Hi,<br /> I
wascurious about the new layout of the data page, so I spent a while looking into the code.<br /> It's interesting, but
Isuspect 2 things are not o.k.:<br /><br /> * gindatapage.c:<u></u>dataIsEnoughSpace() - 'i++' in the for loop should
probablybe 'j++', otherwise it loops forever<br /><br /> * gin_private.h:<u></u>ginDataPageLeafRead() - fetch_att() is
usedto retrieve the additional info, but per the definition and comments in tupmacs.h it expects aligned pointer.<br
/><br/> * gindatapage.c:<u></u>ginCheckPlaceToDataPageLeaf() -  comment "if leaf data page" should probably be "on a
leafdata page" or so.</blockquote><div class="gmail_quote"><br /></div><div class="gmail_quote" style="style">
Hi!</div><divclass="gmail_quote" style="style"><br /></div><div class="gmail_quote" style="style">Thanks for pointing
these.</div><br/>------<br />With best regards,<br />Alexander Korotkov. </div></div></div>