Re: Double sorting split patch

<div class="gmail_quote">On Thu, Sep 22, 2011 at 3:22 PM, Heikki Linnakangas <span dir="ltr"><<a
href="mailto:heikki.linnakangas@enterprisedb.com"target="_blank">heikki.linnakangas@enterprisedb.com</a>></span>
wrote:<br/><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex"><blockquoteclass="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">!               /*<br /> !                * Calculate delta between penalties of join "common
entries"to<br /> !                * different groups.<br /> !                */<br /> !               for (i = 0; i
<commonEntriesCount; i++)<br />                {<br /> !                       double          lower,<br /> !      
                                       upper;<br /> !<br /> !                       box =
DatumGetBoxP(entryvec->vector[<u></u>commonEntries[i].index].key);<br/> !                       if (context.dim ==
0)<br/> !                       {<br /> !                               lower = box->low.x;<br /> !                
             upper = box->high.x;<br /> !                       }<br /> !                       else<br /> !        
             {<br /> !                               lower = box->low.y;<br /> !                               upper
=box->high.y;<br /> !                       }<br /> !                       commonEntries[i].delta =
Abs(box_penalty(leftBox,box) -<br /> !                                                                              
 box_penalty(rightBox,box));<br />                }<br /></blockquote><br /> 'lower' and 'upper' are not used for
anythingin the above. Is that just dead code that can be removed, or is there something missing that should be using
them?</blockquote>Yes,it's just dead code.</div><div class="gmail_quote"><br />------<br />With best regards,<br
/>AlexanderKorotkov. </div>