Re: [HACKERS] [PATCH] kNN for SP-GiST
| От | Alexander Korotkov |
|---|---|
| Тема | Re: [HACKERS] [PATCH] kNN for SP-GiST |
| Дата | |
| Msg-id | CAPpHfdtLbjKiPLgPHM25HGMs096bvmJDmT5E_s38f_2EQTfjpA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [HACKERS] [PATCH] kNN for SP-GiST (Alexander Korotkov <a.korotkov@postgrespro.ru>) |
| Ответы |
Re: [HACKERS] [PATCH] kNN for SP-GiST
|
| Список | pgsql-hackers |
On Thu, Aug 30, 2018 at 3:57 PM Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:
Generally patch looks close to committable shape for me. I'm going to
revise code and documentation again, split it up, and then propose to
commit.
I've revised this patch again. This revision includes a lot of code beautification, adjustments to comments and documentation. Also, after reviewing bug fix [1] I found that we don't need separate memory context for queue. traversalCxt looks perfectly fine for that purpose, because there it's single scan lifetime. Also, it appears to me that it's OK to be a single patch: besides KNN SP-GiST and opclasses it contains only extraction of few common function between GiST and SP-GiST.
So, I'm going to commit this if no objections.
Links.
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Вложения
В списке pgsql-hackers по дате отправления: