Hi, Neil!
On Mon, Jan 25, 2021 at 11:45 AM Neil Chen <carpenter.nail.cz@gmail.com> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: not tested
>
> Greetings,
>
> Although I am not an expert in this field, I carefully read the full-text search section in the document. I think the
changeis surprising, but yes, it is correct.
> I found that your patch didn't modify the regress/excepted/tsearch.out. So I updated it and carried out the
regressiontest. It passed. Also, I manually executed some test cases, all of which were OK.
Thank you for looking into this. Yes, I've adjusted tsearch.sql
regression tests to provide reasonable exercises for the new logic,
but forgot to add tsearch.out to the patch.
BTW, you mentioned you read the documentation. Do you think it needs
to be adjusted accordingly to the patch?
------
Regards,
Alexander Korotkov