Re: Tracking wait event for latches
| От | Alexander Korotkov |
|---|---|
| Тема | Re: Tracking wait event for latches |
| Дата | |
| Msg-id | CAPpHfdsUKLZ5t33p93R2MJwOWuPcZSRiqFAAUfgHa+LXGq7OBg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Tracking wait event for latches (Michael Paquier <michael.paquier@gmail.com>) |
| Ответы |
Re: Tracking wait event for latches
Re: Tracking wait event for latches |
| Список | pgsql-hackers |
Hi, Michael!
On Thu, Aug 4, 2016 at 8:26 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Tue, Aug 2, 2016 at 10:31 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Attached is an updated patch.
Updated version for 2 minor issues:
1) s/stram/stream/
2) Docs used incorrect number
I took a look at your patch. Couple of notes from me.
const char *
GetEventIdentifier(uint16 eventId)
{
const char *res;
switch (eventId)
{
case EVENT_ARCHIVER_MAIN:
res = "ArchiverMain";
break;
... long long list of events ...
case EVENT_WAL_SENDER_WRITE_DATA:
res = "WalSenderWriteData";
break;
default:
res = "???";
}
return res;
}
Would it be better to use an array here?
typedef enum EventIdentifier
{
EventIdentifier seems too general name for me, isn't it? Could we name it WaitEventIdentifier? Or WaitEventId for shortcut?
The Russian Postgres Company
В списке pgsql-hackers по дате отправления: