Re: [PATCH] Allow specification of custom slot for custom nodes
От | Alexander Korotkov |
---|---|
Тема | Re: [PATCH] Allow specification of custom slot for custom nodes |
Дата | |
Msg-id | CAPpHfds4fXCu+5o8TJfdCw3W+9Sp7W3egboXRRygOK35aTth-w@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [PATCH] Allow specification of custom slot for custom nodes (Pavel Borisov <pashkin.elfe@gmail.com>) |
Ответы |
Re: [PATCH] Allow specification of custom slot for custom nodes
|
Список | pgsql-hackers |
On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov <pashkin.elfe@gmail.com> wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation: not tested > > I've looked at this patch and don't see any problems with it. It is minimally invasive, it doesn't affect functionalityunless anyone (e.g. extension) sets its own slotOps in CustomScanState. > Furthermore, the current patch very slightly modifies patch 0b03e5951bf0 with the intention of introducing extensibility.So I think adding more extensibility regarding different tuple formats is an excellent thing to do. > > I'm going to mark it as RfC if there are no objections. Thank you for your feedback. I also don't see how this patch could affect anybody. I'm going to push this if there are no objections. ------ Regards, Alexander Korotkov
В списке pgsql-hackers по дате отправления: