Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
| От | Etsuro Fujita |
|---|---|
| Тема | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. |
| Дата | |
| Msg-id | CAPmGK14TAjv94jGvtPJVf=d067F=XfgmA3F=+3dZTgFMDuCtaA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. (Etsuro Fujita <etsuro.fujita@gmail.com>) |
| Ответы |
Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.
|
| Список | pgsql-hackers |
Hi Gilles, Sorry, I have sent an unfinished email. On Fri, Nov 8, 2019 at 5:20 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote: > On Fri, Nov 8, 2019 at 4:55 PM Gilles Darold <gilles@darold.net> wrote: > > Le 07/11/2019 à 11:52, Etsuro Fujita a écrit : > > > On Thu, Nov 7, 2019 at 5:31 PM Kyotaro Horiguchi > > > <horikyota.ntt@gmail.com> wrote: > > >> I forgot to mention that the comment in XACT_EVENT_PRE_PREPARE > > >> contains the same mistake and needs more or less the same fix. > > > Good catch! How about rewriting "We disallow remote transactions that > > > modified anything" in the comment simply to "We disallow any remote > > > transactions" or something like that? Attached is an updated patch. > > > In the patch, I did s/prepare/PREPARE/ to the error message as well, > > > as you proposed. > > > Looks good for me, Pushed after modifying the commit message a bit. Thanks! Best regards, Etsuro Fujita
В списке pgsql-hackers по дате отправления: