Re: warning to publication created and wal_level is not set to logical
От | Lucas Viecelli |
---|---|
Тема | Re: warning to publication created and wal_level is not set to logical |
Дата | |
Msg-id | CAPjy-54mXB3GOhzkgbAUj3QribUXMfHFE6WN4YsZ+O1W_PXe9w@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: warning to publication created and wal_level is not set to logical (Thomas Munro <thomas.munro@gmail.com>) |
Ответы |
Re: warning to publication created and wal_level is not set to logical
|
Список | pgsql-hackers |
Agreed, fixed. Also run through pgindent
Thank you for the adjustments.
I agree that it's not really worth having tests for this, and I take
your point about the dependency on wal_level that we don't currently
have. The problem is that the core tests include publications
already, and it doesn't seem like a great idea to move the whole lot
to a TAP test. Creating alternative expected files seems like a bad
idea too (annoying to maintain, wouldn't compose well with the next
thing like this). So... how about we just suppress WARNINGs for
CREATE PUBLICATION commands that are expected to succeed? Like in the
attached. This version passes installcheck with any wal_level.
В списке pgsql-hackers по дате отправления: