Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor
| От | Shirley Wang |
|---|---|
| Тема | Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor |
| Дата | |
| Msg-id | CAPG3WN5xjpubO0ZM1XbwU6Q46JVvvRxOirW8HVqGfuS3DqrUdg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor (Dave Page <dpage@pgadmin.org>) |
| Список | pgadmin-hackers |
Hi
It seems like the keyboard shortcuts for commenting got mixed up.
Block commenting: CMD+Shift+/ should comment like /* */
Inline commenting: CMD + / should comment like --
As of now it's reversed.
Shirley
On Wed, Jul 26, 2017 at 7:51 AM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied. I also extended the code you added to ensure the labels for the Find/Replace options are now platform-correct.On Wed, Jul 26, 2017 at 10:29 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Dave,Please find updated patch for new shortcut keys, I have tested it on all three major platforms (macOS, Linux & Windows with Chrome, FF & IE11 Browsers).--Regards,On Fri, Jul 21, 2017 at 9:38 PM, Robert Eckhardt <reckhardt@pivotal.io> wrote:Right - we lose the ability to uncomment multiple levels though, which may also be useful.Well yes.I would argue that simplicity trumps potential use. I'd also argue that attempting to maintain consistency across environments (IDEs, etc. ) is advantageous. This was the philosophy we were going with when enabling excel like behavior (also why I'm not fully happy with how it is today).-- Rob--
В списке pgadmin-hackers по дате отправления: