Re: [PATCH] Proof of concept for GUC improvements

> Hi,
> For parse_special_int():
>
> + * true. If it's not found, return false and retval is set to 0.
> ...
> +   /* don't touch the return value in other case */
> +   return false;
>
> It seems the two comments are not consistent with each other (retval is not set in case no entry is found).
>
> For special_int_to_value():
>
> + * true. If it's not found, return false and retval is set to 0.
>
> First, there is no assignment to retval at the end of the method. Second, retval points to string, so it shouldn't be
setto 0.
 
>
> Cheers

Thanks, I actually noticed on a re-read that the comments didn't
match, but they'll be fixed in the next version. (Will wait to collect
additional feedback.)

Functionality-wise, any thoughts on the overall approach or the specific patch?

Thanks,

David