Re: pgbench - refactor init functions with buffers
| От | Jeevan Ladhe |
|---|---|
| Тема | Re: pgbench - refactor init functions with buffers |
| Дата | |
| Msg-id | CAOgcT0Nwzc1VBa_OSStLUiqYRnEB+_6PE9dHp6-Hw2YYbTTEaA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pgbench - refactor init functions with buffers (Fabien COELHO <coelho@cri.ensmp.fr>) |
| Ответы |
Re: pgbench - refactor init functions with buffers
|
| Список | pgsql-hackers |
I am able to apply the v2 patch with "patch -p1 "
-----
+static void
+executeStatementExpect(PGconn *con, const char *sql, const ExecStatusType expected, bool errorOK)
+{
I think some instances like this need 80 column alignment?
-----
in initCreatePKeys():
+ for (int i = 0; i < lengthof(DDLINDEXes); i++)
+ {
+ resetPQExpBuffer(&query);
+ appendPQExpBufferStr(&query, DDLINDEXes[i]);
I think you can simply use printfPQExpBuffer() for the first append, similar to
what you have used in createPartitions(), which is a combination of both reset
and append.
-----
The pgbench tap tests are also running fine.
Regards,
Jeevan Ladhe
On Tue, Oct 22, 2019 at 8:57 PM Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>> The patch does not apply on master, needs rebase.
>>
>> Hmmm. "git apply pgbench-buffer-1.patch" works for me on current master.
>>
>>> Also, I got some whitespace errors.
>>
>> It possible, but I cannot see any. Could you be more specific?
>
> For me it failing, see below:
>
> $ git log -1
> commit ad4b7aeb84434c958e2df76fa69b68493a889e4a
Same for me, but it works:
Switched to a new branch 'test'
sh> git apply ~/pgbench-buffer-2.patch
sh> git st
On branch test
Changes not staged for commit: ...
modified: src/bin/pgbench/pgbench.c
sh> file ~/pgbench-buffer-2.patch
.../pgbench-buffer-2.patch: unified diff output, ASCII text
sh> sha1sum ~/pgbench-buffer-2.patch
eab8167ef3ec5eca814c44b30e07ee5631914f07 ...
I suspect that your mailer did or did not do something with the
attachment. Maybe try with "patch -p1 < foo.patch" at the root.
--
Fabien.
В списке pgsql-hackers по дате отправления: