Re: [HACKERS] Adding support for Default partition in partitioning
| От | Jeevan Ladhe |
|---|---|
| Тема | Re: [HACKERS] Adding support for Default partition in partitioning |
| Дата | |
| Msg-id | CAOgcT0NeR=+TMRTw6oq_5WrJF+_xG91k_nGUub29Lnv5-qmQHw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [HACKERS] Adding support for Default partition in partitioning (Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>) |
| Ответы |
Re: [HACKERS] Adding support for Default partition in partitioning
|
| Список | pgsql-hackers |
While rebasing the current set of patches to the latest source, I realized
that it might be a good idea to split the default partitioning support patch further
into two incremental patches, where the first patch for default partition
support would prevent addition of any new partition if there exists a default
partition, and then an incremental patch which allows to create/attach a
new partition even if there exists a default partition provided the default
partition does not have any rows satisfying the bounds of the new partition
being added. This would be easier for review.
Here are the details of the patches in attached zip.
0001. refactoring existing ATExecAttachPartition code so that it can be used for
default partitioning as well
0002. support for default partition with the restriction of preventing addition
of any new partition after default partition.
0003. extend default partitioning support to allow addition of new partitions.
0004. extend default partitioning validation code to reuse the refactored code
in patch 0001.
PFA
Regards,
Jeevan Ladhe
On Mon, Jun 12, 2017 at 11:49 AM, Jeevan Ladhe <jeevan.ladhe@enterprisedb.com> wrote:
On Mon, Jun 12, 2017 at 9:39 AM, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote: While the refactoring seems a reasonable way to re-use existing code,
that may change based on the discussion in [1]. Till then please keep
the refactoring patches separate from the main patch. In the final
version, I think the refactoring changes to ATAttachPartition and the
default partition support should be committed separately. So, please
provide three different patches. That also makes review easy.Sure Ashutosh,PFA.
Вложения
В списке pgsql-hackers по дате отправления: