Re: [HACKERS] Bug in get_partition_for_tuple
| От | Jeevan Ladhe |
|---|---|
| Тема | Re: [HACKERS] Bug in get_partition_for_tuple |
| Дата | |
| Msg-id | CAOgcT0MFpo1=Z3Qpiub0KLGuqS1sxgVpNNoZ+nSrkKht1_ArrA@mail.gmail.com обсуждение исходный текст |
| Ответ на | [HACKERS] Bug in get_partition_for_tuple (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>) |
| Ответы |
Re: [HACKERS] Bug in get_partition_for_tuple
|
| Список | pgsql-hackers |
Hi Amit,
I was able to reproduce the crash, and with the attached patch the crash goes
away. Also, "make check-world" passes clean.
Patch looks good to me. However, In following comment in your test:
-- check routing error through a list partitioned table when they key is null
I think you want to say:
-- check routing error through a list partitioned table when the key is null
Thanks,
Jeevan Ladhe
On Fri, Mar 10, 2017 at 8:26 AM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
Just observed a crash due to thinko in the logic that handles NULL
partition key. Absence of null-accepting partition in this case should
have caused an error, instead the current code proceeds with comparison
resulting in crash.
create table p (a int, b char) partition by list (b);
create table p1 partition of p for values in ('a');
insert into p values (1); -- crashes
Attached patch fixes that and adds a test.
Thanks,
Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
В списке pgsql-hackers по дате отправления: