Patch for SonarQube fixes.

Поиск
Список
Период
Сортировка
От Nikhil Mohite
Тема Patch for SonarQube fixes.
Дата
Msg-id CAOBg0AO3tVZMT68DyMLyc6w+za9sHA+NHEs_rosfVGNP=kgxeQ@mail.gmail.com
обсуждение исходный текст
Ответы Re: Patch for SonarQube fixes.  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Team,

I have fixed a few sonarQube issues, PFA patch
Details as follows:

1. Preferences:
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
  • Merge this if statement with the enclosing one.
  • Define a constant instead of duplicating this literal 'tab settings' 5 times.
2. Connection:
  • Remove this unneeded "pass".
3. Sqleditor:
  • Remove this useless assignment to variable "msgDiv".
4. Debugger:
  • Review this useless assignment: "index" already holds the assigned value along all execution paths.
  • 'label' is already declared in the upper scope.
  • 'label' is already declared in the upper scope.
  • 'browser_preferences' is already declared in the upper scope.
5. FileManager:
  • 'path' is already declared in the upper scope.

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Aditya Toshniwal
Дата:
Сообщение: Re: [pgAdmin][RM1802] ERD Tool (Beta)
Следующее
От: Khushboo Vashi
Дата:
Сообщение: Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1