Re: Add parallelism and glibc dependent only options to reindexdb
От | Julien Rouhaud |
---|---|
Тема | Re: Add parallelism and glibc dependent only options to reindexdb |
Дата | |
Msg-id | CAOBaU_b=P+H9EZZuZ+kMEScz6iHpz8S3ZMrrrZcQ6zWmWJ425Q@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Add parallelism and glibc dependent only options to reindexdb (Michael Paquier <michael@paquier.xyz>) |
Ответы |
Re: Add parallelism and glibc dependent only options to reindexdb
|
Список | pgsql-hackers |
On Fri, Jul 26, 2019 at 9:41 AM Michael Paquier <michael@paquier.xyz> wrote: > > On Fri, Jul 26, 2019 at 09:36:32AM +0200, Julien Rouhaud wrote: > > I see that you iterate over the SimpleStringList after it's generated. > > Why not computing that while building it in get_parallel_object_list > > (and keep the provided table list count) instead? > > Yeah. I was hesitating to do that, or just break out of the counting > loop if there are more objects than concurrent jobs, but that's less > intuitive. That's probably still more intuitive than having the count coming from either main() or from get_parallel_object_list() depending on the process type, so I'm fine with that alternative. Maybe we could bite the bullet and add a count meber to Simple*List, also providing a macro to initialize a new list so that next time a field is added there won't be a massive boilerplate code change?
В списке pgsql-hackers по дате отправления: