Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Akshay!

 

Some test file names ended with "_sql_template.py" do we need to add that string ? 

we added this suffix after moving the tests up a level to tables/tests to clarify what subject they applied to. we changed the suffix to "_sql.py"

- Files "test_column_acl_sql_template.py" and "test_column_properties_sql_template.py" should be moved from tables->tests to tables->column->tests. As it's related to column.
- Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_sql_template.py" should be moved from tables->tests to tables->triggers->tests. As its related to triggers.

these tests are related to the sql files in tables/templates/column, not tables/column, so moving them into tables/column would be more confusing. 

Following test cases are failing

Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql doesn't fail in your environment?

Thanks,

George & Sarah