Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous runningon CI sytems
Thanks patch applied with following changes:
- Remove "self._screenshot()" method from each feature test as it will take screenshot every time even though test case will execute successfully.
- Fix pep8 issues.
- Remove unnecessary blank lines.
- Change function name from "setTestDbName" to "setTestDatabaseName".
- Modify some comments and strings.
On Mon, Aug 20, 2018 at 6:18 PM, Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:
Hi Hackers,Attached is the patch for feature tests, mostly fix issues due to which test cases were failing on jenkins. It has the following fixes,
- Added code to Create testing db node from runtests.py with random number in name to avoid naming conflicts in parallel execution on different platforms.
- Added code to delete testing db node from runtest.py.
- Removed the code to add and delete testing db with name "acceptacne_test_db" in each feature test cases.
- Added `setTestDbName` method in route.py module , through which testing db name will be available for all feature tests.
- xpath/css selectors changes where applicable. Where it was possible I have used css selectors.
- sqleditor.js - added the code to render
Explain Options submenue on left side on small screen.- Increased the timeout for application from 60 to 90 seconds.
- Change the logic for reset layout funciton.
Last successful execution on all platfroms can be seen on following link--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
В списке pgadmin-hackers по дате отправления: