Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcuttools bar for frequently used features

Hi

On Thu, Sep 6, 2018 at 1:19 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Hackers, 

I have implemented the Feature #3564 pgAdmin4 should have shortcut tools bar for frequently used features. As per discussion I have added buttons on the "Browser" Panel. 

Thanks to Ashesh as he has modified the wcDocker code and added following:

• Added support to specify parent class which will be added to the parent node of the wcFrameButton. This is required for the identification of the button and enable/disable it.
• Added support to enable/disable the wcFrameButton using label.     
  

Attached is the patch file which contains implementation and feature test. There is a change in package.json file, so need to run yarn install after applying the patch.

Very nice!

Couple of pieces of feedback:

- Are there any relevant docs that need updating?

- Can we make the buttons look like regular toolbar buttons (only smaller)? They look quite different from the toolbar buttons on the query tool and debugger, and I think should have the same stying (not that of the tabset control buttons which I'd argue are semantically different in purpose).

Thanks!

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company