Re: [pgAdmin4][Patch] - RM #7179 - PostgreSQL deployment on EDB BigAnimal

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin4][Patch] - RM #7179 - PostgreSQL deployment on EDB BigAnimal
Дата
Msg-id CANxoLDe8KU-gnow=cY1Esbh-ZzGj0LFSDRLW2+cbmqJW_UU57A@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch] - RM #7179 - PostgreSQL deployment on EDB BigAnimal  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] - RM #7179 - PostgreSQL deployment on EDB BigAnimal
Список pgadmin-hackers
Дерево обсуждения
Hi Khushboo

Following are the review comments:
GUI:
  • Facing error in the browser. Please check the below screenshot
             2nd Page.png
  • Unable to test ahead because 'Regions' are not available to select in the dropdown. Even the code has been verified successfully
                  Code.png.        Region_Error.png


Code:
  • Jasmine test cases are missing.
  • Documentation is missing.
  • Function comments are not present in the new files. Overall very less comments about the code. Add comments in rds.py and io.py
  • Access token gets printed at the backend, it should not or at least should be in the Debug log.
  • Move BASE_URL = 'https://portal.biganimal.com/api/v1' to constants.py and remove it from the multiple files.
  • Fixed SonarQube issues from the new files and from existing files if introduced with this patch or previous patch for AWS RDS.
  • Update line "help='Amazon AWS RDS PostgreSQL'" in BigAnimal.py.
  • sid = _create_server({
        'gid': data['db_details']['gid'],
        'name': data['instance_details']['cluster_name'],
        'db': 'edb_admin',
        'username': 'edb_admin',
        'port': 5432,
        'cloud_status': -1
    }).  Update Why db, username and port are hard coded?
  • In "misc/cloud/__init__.py" two function with same name "def get_db_versions()"
  • Correct the string "edb_bibanimal_authentication" to "edb_biganimal_authentication" in CloudWizard.jsx and 'VigAnimal Volume Types" to "BigAnimal Volume Types".

On Thu, Apr 14, 2022 at 2:04 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for the implementation of the RM #7179 - PostgreSQL deployment on EDB BigAnimal.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Вложения

В списке pgadmin-hackers по дате отправления: