Re: [pgAdmin][RM5398] Bad display of tables storage parameters in the "SQL" tab

Hi Hackers,

Attached is the patch to:

1) Fix the SQL generated for autovacuum options. It was not displaying the vacuum options until autovacuum_enabled is set to true. Vacuum options setting does not depend on autovacuum_enabled, and this was being wrongly interpreted by pgAdmin.

2) pgAdmin allows only true or false values for autovacuum_enabled, and there is no way to reset it individually without disabling custom autovacuum. To fix this, the control is changed from switch to three state buttons. Screenshot below:

3) Setting any vacuum options to zero made the option disappear from the SQL.

4) Right click on a table with vacuum options set and create a new table. The parameters tab will have the options prefilled. This is fixed.

5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.

6) The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".

7) Test cases updated to increase the scenarios.

8) Documentation update.

Please review.

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"