Re: [pgadmin4][patch] [GreenPlum] Partitioned table icon is the sameas non partitioned tables

Поиск

Список

Период

Сортировка

От	Akshay Joshi
Тема	Re: [pgadmin4][patch] [GreenPlum] Partitioned table icon is the sameas non partitioned tables
Дата	26 апреля 2018 г. 17:43:25
Msg-id	CANxoLDdaiy7YSHJEwwwwAVnnK7Hq4zo=J9Ugb5Gi1N_qMYRYyQ@mail.gmail.com обсуждение исходный текст
Ответ на	[pgadmin4][patch] [GreenPlum] Partitioned table icon is the same asnon partitioned tables (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Список	pgadmin-hackers

Дерево обсуждения

Thanks Patch applied.

On Wed, Apr 25, 2018 at 2:17 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hi Hackers,
Attached you can find 2 patches that correct the Redmine: #3308 A
Patches:
0001 - In this patch we update the SQL to retrieve the is_partitioned flag from the database
0002 - Extract and refactor the icon css class retrieval. It was scattered around the code and we moved it into it's own small class

We also realize that the class was present in some places in the javascript world. What it is strange is that we only override the icon with the partition one after a successful truncation or successful reset of statistics.
Why was this behavior added? Can we remove that?

Are you referring to "partition.js"? If yes then according to me it's valid because for partitions we only override the icon with the partition one. Please correct me if I am wrong.