RM #1250 Collection node counts

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема RM #1250 Collection node counts
Дата
Msg-id CANxoLDd4-bmH9jtT1Ki4MD3kBmt15MF2yOWsa7LyGWcgo-kGzQ@mail.gmail.com
обсуждение исходный текст
Ответы Re: RM #1250 Collection node counts  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi All

I have fixed the RM#1250 "Collection node counts". To fix this RM I need to do following changes
  • Move "check_precondition" function from module's view class to global level within that python file itself, so that module class will use it. 
  • Modified "get_nodes" function of each module's class, run the sql query to count the number of objects and pass the count to "generate_browser_collection_node" function to display the collection count.
  • Reuse SQL queries which is used to fetch nodes. Make that query as inner query like "SELECT count(*) FROM( <node's> query  ) AS collection_count". For that I'll have to remove semicolon's from some of the SQL queries.
One case is not handled with this patch and that is on "Refresh" of collection node, count is not updated. If user refresh the parent node then it will be updated. I'll create a separate RM for that.

Attached is the patch file. Please review it and let me know the review comments.           

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin 4 - Bug #1523] Messages pane showing incomplete info
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Prevent the user attempting to run external commands