Re: [pgAdmin] Fix incorrect import in setup.py
От | Akshay Joshi |
---|---|
Тема | Re: [pgAdmin] Fix incorrect import in setup.py |
Дата | |
Msg-id | CANxoLDcYv6xonh73Y0wLrb=w+hCW7dR2bVXJuvR6zhZGSQmeHA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgAdmin] Fix incorrect import in setup.py (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>) |
Список | pgadmin-hackers |
Thanks, patch applied.
On Mon, Sep 28, 2020 at 4:48 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Azad,The patch looks good to me.On Thu, Sep 24, 2020 at 6:33 PM Azad Salahlı <azad.salahli@gmail.com> wrote:Hi,
First time posting here. I've attached a fix for an incorrect import
in `setup.py`. Trying to import from `pgadmin` before adding the root
directory to the system path results in import error, when the script
is invoked in any other way than running it directly. For example
$ /path/to/venv/bin/pip install pgadmin4
$ /path/to/venv/bin/python -m pgadmin4.setup
Traceback (most recent call last):
...
File "/path/to/venv/lib/python3.6/site-packages/pgadmin4/setup.py",
line 18, in <module>
from pgadmin.model import db, User, Version, ServerGroup, Server, \
ModuleNotFoundError: No module named 'pgadmin'
Please let me know what you think. Happy to address any feedback.
Regards,
Azad Salahlı--Thanks,Aditya ToshniwalpgAdmin hacker | Sr. Software Engineer | edbpostgres.com"Don't Complain about Heat, Plant a TREE"
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB PostgresMobile: +91 976-788-8246
В списке pgadmin-hackers по дате отправления: