Re: [pgAdmin][RM-6687]: [React] Port Grant Wizard to react

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM-6687]: [React] Port Grant Wizard to react
Дата
Msg-id CANxoLDcSAwchWE8CN8hLzJ8yg_xCSCitpoVsuo6Ya4CrfrWYZw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM-6687]: [React] Port Grant Wizard to react  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Ответы Re: [pgAdmin][RM-6687]: [React] Port Grant Wizard to react  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Nikhil

Following are the GUI related review comments:
  1. Remove the header string "Object selection (step 1 of 3) as we are already showing steps on the left side of the wizard.
  2. Rename step 1 to "Object Selection" step 2 to "Privilege Selection" and step 3 to "Review Selection".
  3. The search button is not implemented on the first page (object selection).
  4. The help button is not implemented at the bottom left corner of the wizard.
  5. Duplicate entries are found on the object selection page. (Seems like an old issue without this patch)
  6. Checkbox checked color should be matched with the theme.
  7. Scrollbar alignment is not correct and spaces at the right side and bottom look ugly.
  8. The grantor should be set and read-only.
  9. Showing all privileges instead of based on the selected node. Please refer to existing behavior.
Refer screenshot with all above review comments

Object Selection.png
:



On Tue, Sep 14, 2021 at 1:19 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find the updated patch for grant wizard porting to react. (Please ignore the previous patch)

On Tue, Sep 14, 2021 at 10:05 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for RM-6687: [React] Port Grant Wizard to react


--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.

Regards,
Nikhil Mohite 


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: pgagent_upgrade.sql does not exist
Следующее
От: Pradip Parkale
Дата:
Сообщение: Re: [pgAdmin][RM2546]: Partitioned table should be created using COLLATE and opclass.