[pgAdmin4][Patch]: RM #3277 Runtime startup error handling is brokenon Windows.

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is brokenon Windows.
Дата
Msg-id CANxoLDcBHYpsK3+ijxh-xXKnPbe39iMZpk4QyMHE5VYahqAw=Q@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling isbroken on Windows.  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hi Hackers,

Please find the attached patch to fix RM #3277 Runtime startup error handling is broken on Windows.

This issue is regression of RM #3177 "Sporadically crashes on Windows when exit". Where below code of pgAdmin4.cpp creates the problem:
QObject::connect(server, SIGNAL(finished()), server, SLOT(deleteLater()));

In case when PythonPath is not provided then application server not started and server thread finished there execution, due to the above line of code Destructor of Server class has been called and we are accessing the function server->getError().length() at line no 251 of pgAdmin4.cpp, which cause the application crash.

I have removed that line and tested RM #3177 and RM# 3277, both are working fine.

Please review and test it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Xuri Gong
Дата:
Сообщение: GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS
Следующее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling isbroken on Windows.