Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

The patch looks good to me.

On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo 

Can you please review it.

On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please find attached updated patch.

In this patch I have fixed two issues:

i. Dialog tab navigation should work even if focus is on footer buttons (Save, Cancel, etc..)

ii. Focus should be set to first editable element of dialog when tab cycle goes through all editable footer buttons.

-- 

Harshal Dhumal

Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

This patch fixes Dialog tabset keyboard navigation.

This regression was caused due to bootstrap 4 changes.

Also I have added jasmine test cases for the same

-- 

Harshal Dhumal

Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246