Re: [pgAdmin4][Patch] - RM 4742 - Can not create Primary key withIndex & 4624 - RE-SQL/MSQL test cases for Primary Keys

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin4][Patch] - RM 4742 - Can not create Primary key withIndex & 4624 - RE-SQL/MSQL test cases for Primary Keys
Дата
Msg-id CANxoLDc-3Z_6LOmtnyxjMZN=y+k7atHJTqY0Ma7FvARFvJc+Og@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch] - RM 4742 - Can not create Primary key with Index &4624 - RE-SQL/MSQL test cases for Primary Keys  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] - RM 4742 - Can not create Primary key withIndex & 4624 - RE-SQL/MSQL test cases for Primary Keys
Список pgadmin-hackers
Дерево обсуждения
Hi Khushboo 

Following are my review comments: 
  • Test cases failed on every server.
  • Delete table scenario is missing in check_constraints and index_constraints.
  • Scenario "Primary Key Constraint with Index" is missing in the 11_plus folder, it is available in the default folder.
  • Found one issue when we remove fill factor no MSQL is generated and got the error "can't execute an empty query". 
  • Index is not visible in the properties dialog when we create primary key using index. 

On Fri, Sep 13, 2019 at 2:41 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix below RMs.

1. #4742 - Primary Key Dialog: Can not create Primary key with Index
2. #4624 - Add RE-SQL/MSQL test cases for Primary Keys

Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления: