Re: Container build hanging
| От | Victoria Henry |
|---|---|
| Тема | Re: Container build hanging |
| Дата | |
| Msg-id | CANxYE3Ji0Y_dYcS-bXNfNLpjmWHyjnR1sW2UaSrkhM-5wjxccw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Container build hanging (Dave Page <dpage@pgadmin.org>) |
| Ответы |
Re: Container build hanging
|
| Список | pgadmin-hackers |
Hey Dave,
The reason that it was taking so long was because the linter was acting on the javascript in the ycache directory in the container. The fix is to add the ycache directory to the .eslintignore file. We can send a patch file, if you’d like:
diff --git a/web/.eslintignore b/web/.eslintignore
index 7468ecb8..676a4f03 100644
--- a/web/.eslintignore
+++ b/web/.eslintignore
@@ -3,3 +3,4 @@ node_modulesvendortemplates/templates\
+ycache
We'd prefer using the linter via the command line over the javascript config (that never worked well).
Thanks
Victoria && Anthony
On Wed, May 30, 2018 at 5:43 PM Dave Page <dpage@pgadmin.org> wrote:
HiSo it turns out the hang was a result of:=====Using the '.eslintignore' config file for excluding the temporary,
vendor specific, and templates files, instead of writing our own logic
to do so.
Patch by: Anthony & Joao
Reviewed by: Khushboo
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a7ee85619dfd4cf42a43919beeb1cd1680f46d53
Author: Anthony Emengo <aemengo@pivotal.io>
Modified Files
--------------
web/.eslintignore | 5 +++++
web/package.json | 2 +-
web/pga_eslint.js | 44 --------------------------------------------
3 files changed, 6 insertions(+), 45 deletions(-)=====Reverting that one patch fixes the issue. Can one or more of you take a look please?Note that running the Docker build is easy - just install Docker and run "make docker". However, it uses committed code in the build, so any changes need to be committed to your local tree or they'll be ignored (yes, we need to fix that).Thanks!On Wed, May 30, 2018 at 3:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiThe container build is hanging for me on 2 different machines at:20:19:50 $ cross-env NODE_ENV=production yarn run bundle:dev20:19:51 $ yarn run linter && yarn run webpacker20:19:52 $ yarn eslint --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .20:19:52 $ /pgadmin4/web/node_modules/.bin/eslint --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .Both systems (a Jenkins build node and my laptop) hang at that step, seemingly indefinitely.Running the same (e.g. yarn eslint --no-eslintrc -c .eslintrc.js --ext .js --ext .jsx .) is fine directly on my laptop.Anyone got any ideas why that may be? The only thing I can think of is the overly cute unicode symbols that yarn is spitting out may be confusing docker.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: