Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row
| От | Hamid Akhtar |
|---|---|
| Тема | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row |
| Дата | |
| Msg-id | CANugjhu3n6Uj3np-FXF3tyyeHBdj1sr3i0HXtaa88qE0sL4k0w@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row (Ibrar Ahmed <ibrar.ahmad@gmail.com>) |
| Список | pgsql-hackers |
On Tue, 6 Sept 2022 at 11:25, Ibrar Ahmed <ibrar.ahmad@gmail.com> wrote:
The patch has a compilation error on the latest code base, please rebase your patch.On Mon, Aug 1, 2022 at 11:29 PM Naeem Akhter <naeem.akhter@percona.com> wrote:The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Looks good to me.
The new status of this patch is: Ready for Committer
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:27: error: ‘result’ was not declared in this scope
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
[03:08:46.087] | ^~~~~~
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:40: error: expected primary-expression before ‘scanbuflen’
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);...
--Ibrar Ahmed
The compilation and regression are working fine. I have verified it against the tip of the master branch [commit: 57796a0f].
В списке pgsql-hackers по дате отправления: