Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals

Поиск
Список
Период
Сортировка
От James Sewell
Тема Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals
Дата
Msg-id CANkGpBu-Bj4_tRSr2jPvQOG9vfzAqUnKQNus2mct5i_7H+SkdA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals  (Peter Eisentraut <peter_e@gmx.net>)
Ответы Re: [PATCH] Add an ldapoption to disable chasing LDAP referrals  (Peter Eisentraut <peter_e@gmx.net>)
Список pgsql-hackers
Hey All,

I had missed these emails, sorry.

The search+bind mode issue is one of documentation location, I have fixed it by moving the section to the applied to both list. As the patch is to do with post-auth response this is correct.

As far as the issue when something other than 0 or 1 is set I am happy throw an error (although this doesn't seem to be how option such as LDAPTLS work: 1 if 1 else 0). I assume I would use the ereport() function to do this (using the second example from this page http://www.postgresql.org/docs/9.2/static/error-message-reporting.html)?

Cheers,
James


James Sewell,
PostgreSQL Team Lead / Solutions Architect
______________________________________
 

Level 2, 50 Queen St, Melbourne VIC 3000

(+61) 3 8370 8000  W www.lisasoft.com  (+61) 3 8370 8099
 


On Thu, Sep 19, 2013 at 12:56 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
On 7/8/13 9:33 PM, James Sewell wrote:
> New patch attached. I've moved from using a boolean to an enum trivalue.

When ldapreferrals is set to something other than "0" or "1" exactly, it
just ignores the option.  That's not good, I think.  It should probably
be an error.




The contents of this email are confidential and may be subject to legal or professional privilege and copyright. No representation is made that this email is free of viruses or other defects. If you have received this communication in error, you may not copy or distribute any part of it or otherwise disclose its contents to anyone. Please advise the sender of your incorrect receipt of this correspondence.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: psql tab completion for updatable foreign tables
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Patch for reserved connections for replication users