Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

Поиск
Список
Период
Сортировка
От Neha Sharma
Тема Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Дата
Msg-id CANiYTQvSru_CjYNYDyDi2NM2__Cx6Jw9KpCOAZhgpWsAHksJkw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Hi,

I have done code coverage analysis on the latest patches(v53) and below is the report for the same.
Highlighted are the files where the coverage modifications were observed.

OS: Ubuntu 18.04
Patch applied on commit : 77c7267c37f7fa8e5e48abda4798afdbecb2b95a

File Name
Coverage
Without logical decoding patchOn v53 (2,3,4,5) patch Without v53-0003 patch
%Line%Function%Line%Function%Line%Function
src/backend/access/transam/xact.c86.292.986.292.986.292.9
src/backend/access/transam/xloginsert.c90.294.190.294.190.294.1
src/backend/access/transam/xlogreader.c73.393.373.893.373.893.3
src/backend/replication/logical/decode.c93.410093.410093.4100
src/backend/access/rmgrdesc/xactdesc.c54.463.654.463.654.463.6
src/backend/replication/logical/reorderbuffer.c93.496.793.496.793.496.7
src/backend/utils/cache/inval.c98.110098.110098.1100
contrib/test_decoding/test_decoding.c86.895.286.895.286.895.2
src/backend/replication/logical/logical.c90.993.590.993.591.893.5
src/backend/access/heap/heapam.c86.194.586.194.586.194.5
src/backend/access/index/genam.c90.791.791.291.791.291.7
src/backend/access/table/tableam.c90.610090.610090.6100
src/backend/utils/time/snapmgr.c81.198.180.298.181.198.1
src/include/access/tableam.h92.510092.510092.5100
src/backend/access/heap/heapam_visibility.c77.810077.810077.8100
src/backend/replication/walsender.c90.597.890.597.890.9100
src/backend/catalog/pg_subscription.c961009610096100
src/backend/commands/subscriptioncmds.c93.29092.79092.790
src/backend/postmaster/pgstat.c64.285.163.985.164.686.1
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c82.49582.59583.695
src/backend/replication/logical/proto.c93.591.393.793.393.793.3
src/backend/replication/logical/worker.c91.69691.597.491.997.4
src/backend/replication/pgoutput/pgoutput.c81.910085.510086.2100
src/backend/replication/slotfuncs.c9393.89393.89393.8
src/include/pgstat.h100-100-100-
src/backend/replication/logical/logicalfuncs.c87.19087.19087.190
src/backend/storage/file/buffile.c68.38569.68569.685
src/backend/storage/file/fd.c81.19381.19381.193
src/backend/storage/file/sharedfileset.c77.790.993.210093.2100
src/backend/utils/sort/logtape.c94.410094.410094.4100
src/backend/utils/sort/sharedtuplestore.c90.190.990.190.990.190.9

Thanks.
--
Regards,
Neha Sharma


On Thu, Aug 27, 2020 at 11:16 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Wed, Aug 26, 2020 at 11:22 PM Jeff Janes <jeff.janes@gmail.com> wrote:
>
>
> On Tue, Aug 25, 2020 at 8:58 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
>>
>>  I am planning
>> to push the first patch (v53-0001-Extend-the-BufFile-interface) in
>> this series tomorrow unless you have any comments on the same.
>
>
>
> I'm getting compiler warnings now, src/backend/storage/file/sharedfileset.c line 288 needs to be:
>
> bool        found PG_USED_FOR_ASSERTS_ONLY = false;
>

Thanks for the report. Tom Lane has already fixed this [1].

[1] - https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=e942af7b8261cd8070d0eeaf518dbc1a664859fd

--
With Regards,
Amit Kapila.


В списке pgsql-hackers по дате отправления: