Re: Mention column name in error messages
От | Franck Verrot |
---|---|
Тема | Re: Mention column name in error messages |
Дата | |
Msg-id | CANfkH5kpCcPMy-8a+FAFz4-ba6AYo+YXhp+kELUoNGv0=gUS3w@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Mention column name in error messages (Michael Paquier <michael.paquier@gmail.com>) |
Список | pgsql-hackers |
On Sun, Oct 30, 2016 at 12:04 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
Okay, so I have reworked the patch a bit and finished with the
attached, adapting the context message to give more information. I
have noticed as well a bug in the patch: the context callback was set
before checking if the column used for transformation is checked on
being a system column or not, the problem being that the callback
could be called without the fields set.
Interesting. I wasn't sure it was set at the right time indeed.
I have updated the regression tests that I found, the main portion of
the patch being dedicated to that and being sure that all the
alternate outputs are correctly refreshed. In this case int8, float4,
float8, xml and contrib/citext are the ones impacted by the change
with alternate outputs.
Thanks! I couldn't find time to update it last week, so thanks for chiming in.
I am passing that down to a committer for review. The patch looks
large, but at 95% it involves diffs in the regression tests,
alternative outputs taking a large role in the bloat.
Great, thanks Michael!
--
Franck
В списке pgsql-hackers по дате отправления: