Re: pg_basebackup wish list

On 19 August 2016 at 08:46, Michael Paquier <michael.paquier@gmail.com> wrote:
> On Fri, Aug 19, 2016 at 2:04 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> I agree with adding this as an option and removing directory by default.
>> And it looks good to me except for missing new line in usage output.
>>
>>         printf(_("  -l, --label=LABEL      set backup label\n"));
>> +       printf(_("  -n, --noclean          do not clean up after errors"));
>>         printf(_("  -P, --progress         show progress information\n"));
>>
>> Registered this patch to CF1.
>
> +1 for the idea. Looking at the patch it is taking a sane approach.

Apart from this one liner change we look good to go.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services