Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

On 19 November 2017 at 20:30, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2017-11-19 19:49:01 -0500, Tom Lane wrote:
>>> TBH, I would just remove those test cases.  Even if they were stable
>>> across platforms, they don't directly prove anything at all about
>>> whether the feature does what it's supposed to.
>
>> I think it might make sense to rewrite the tests so it doesn't output
>> any of the sizes, but instead just compares the size of tables with
>> different thresholds. That should be fairly reliable.
>
> Hm, what I'd try after a bit of thought is to stuff the same data
> into two different tables with different settings chosen to make it
> TOAST or not, and then just test the toast tables for zero or nonzero
> size.

Roughly that.

> Setting STORAGE = EXTERNAL on the data column to disable
> compression would help make things more stable, too.

That was already set at line 350

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services