On January 11, 2016 8:57:58 PM GMT+01:00, Simon Riggs <simon@2ndQuadrant.com> wrote: >On 11 January 2016 at 18:43, Simon Riggs <simon@2ndquadrant.com> wrote:
>It's clear there are various additional tuning opportunities, but the >objective of the current patch to improve performance is very, very >clearly >met, so I'm aiming to commit *this* patch soon.
Again, the WAL read routine used doesn't deal with timeline changes.
Not relevant: The direct WAL read routine is never used during replay, so your comment is not relevant since we don't change timelines on the master.
So no, it's bit ready to be committed.
I will update the comment on that function to explain its usage and its limitations for future usage, to make that clearer.
--
Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services