Re: meson: Non-feature feature options
От | Nazir Bilal Yavuz |
---|---|
Тема | Re: meson: Non-feature feature options |
Дата | |
Msg-id | CAN55FZ0srpj+=E1e6ryTP8avb6HW24M18yct-JoZHMmRtM-ACA@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: meson: Non-feature feature options (Peter Eisentraut <peter.eisentraut@enterprisedb.com>) |
Ответы |
Re: meson: Non-feature feature options
|
Список | pgsql-hackers |
Hi, On Wed, 22 Feb 2023 at 12:14, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote: > > On 21.02.23 17:32, Nazir Bilal Yavuz wrote: > >>> I like the second approach, with a 'uuid' feature option. As you wrote > >>> earlier, adding an 'auto' choice to a combo option doesn't work fully like a > >>> real feature option. > >> But we can make it behave exactly like one, by checking the auto_features > >> option. > > Yes, we can set it like `uuidopt = get_option('auto_features')`. > > However, if someone wants to set 'auto_features' to 'disabled' but > > 'uuid' to 'enabled'(to find at least one working uuid library); this > > won't be possible. We can add 'enabled', 'disabled and 'auto' choices > > to 'uuid' combo option to make all behaviours possible but adding > > 'uuid' feature option and 'uuid_library' combo option seems better to > > me. > > I think the uuid side of this is making this way too complicated. I'm > content leaving this as a manual option for now. > > There is much more value in making the ssl option work automatically. > So I would welcome a patch that just makes -Dssl=auto work smoothly, > perhaps using the "trick" that Andres described. I tried to implement what we did for ssl to uuid as well, do you have any comments? Regards, Nazir Bilal Yavuz Microsoft
Вложения
В списке pgsql-hackers по дате отправления: