Re: FETCH FIRST clause PERCENT option
| От | Ryan Lambert |
|---|---|
| Тема | Re: FETCH FIRST clause PERCENT option |
| Дата | |
| Msg-id | CAN-V+g_cG4_R9q25nccNoMrtwA7DsCuHh-G5_ygaj8PBFTWUDw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: FETCH FIRST clause PERCENT option (Surafel Temesgen <surafel3000@gmail.com>) |
| Ответы |
Re: FETCH FIRST clause PERCENT option
|
| Список | pgsql-hackers |
On Thu, Sep 19, 2019 at 6:52 AM Surafel Temesgen <surafel3000@gmail.com> wrote:
Hi Tom,In the attached patch i include the comments givenregardsSurafel
Patch v9 applies and passes make installcheck-world.
> From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Date: 2019-09-05 22:26:29
> * I didn't really study the changes in nodeLimit.c, but doing
> "tuplestore_rescan" in ExecReScanLimit is surely just wrong. You
> probably want to delete and recreate the tuplestore, instead, since
> whatever data you already collected is of no further use. Maybe, in
> the case where no rescan of the child node is needed, you could re-use
> the data already collected; but that would require a bunch of additional
> logic. I'm inclined to think that v1 of the patch shouldn't concern
> itself with that sort of optimization.
I don't think this was addressed.
Ryan Lambert
В списке pgsql-hackers по дате отправления: