Re: 9.2 beta2 - pg_ctl crashes on Win32 when neither PGDATA nor -D specified

On 12 June 2012 14:23, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Edmund Horner <ejrh00@gmail.com> writes:
>> In 9.1, if I run "pg_ctl start" without providing way for it to find
>> the datadir, it prints the error:
>
>> =A0 =A0 C:\ehorner\pgsql-old\bin>pg_ctl start
>> =A0 =A0 pg_ctl: no database directory specified and environment variable
>> PGDATA unset
>> =A0 =A0 Try "pg_ctl --help" for more information.
>
>> In 9.2 (beta1 and beta2), it runs for a couple of seconds and then
>> Windows pops up an error box saying it has "encountered a problem". =A0I
>> ...
>> I think it could be something in
>> http://git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dcommitdiff;h=3D=
aaa6e1def292cdacb6b27088898793b1b879fedf#patch5
>
> Hm, that patch seems to be several bricks shy of a load. =A0I will fix
> two obvious bugs in it:
>
> (1) not dump core on boxes where printf("%s", NULL) dumps core;

I saw that, but I couldn't decide if it was the actual problem in my
case.  Later parts of adjust_data_dir appeared to be running (looking
at file system activity).

Anyway I'm happy to test it again when there's a new binary.

Edmund.